Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix(#1425): Streamlining cortex run behavior #1520

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(#1425): Streamlining cortex run behavior #1520

merged 1 commit into from
Oct 21, 2024

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented Oct 19, 2024

Describe Your Changes

  • Default to attach mode when run cortex run <model_id>
  • Allow run / chain command to run in detach mode cortex run <model_id> -d/--detach

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai merged commit a6b64f8 into dev Oct 21, 2024
4 checks passed
@namchuai namchuai deleted the j/fix-streamlining-cortex-run branch October 21, 2024 01:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

1 more reviewer

@vansangpfiev vansangpfiev vansangpfiev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Streamlining cortex run behavior

3 participants

@namchuai @vansangpfiev